Record Of Code Review
---- Subject : Custom Shape
---- Spec: DAT-1925
---- Suggests:
一、ISymbolShapeDefination
1、 The style parameter in the contains method should not be a optional option
Reason :The default value of style should not be defined by ISymbolShapeOption
2、Color should be removed from defination
Reason: The color is a instance, not a defination. For example:
If there are two symbols , one is red color and another is blue color , you can't
distinguish these two colors by using current design
二、ISymbolShapeOption
1、Change the option name from "path" to "content"
Reason: In order to have a better expansion in the future, for examples :
we can support svg path or image path and so on
---- Questions:
1、Should we need the style parameter for render method in ISymbolShapeDefination？
Answer : Currently , ISymbol still uses the style and it will be marked to discard,
so we will remove style in the future